Add package and source package batching for publish #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstct
force-pushed
the
add_batching_for_publish
branch
10 times, most recently
from
38e7a34
to
25a30c3
Compare
hstct
force-pushed
the
add_batching_for_publish
branch
5 times, most recently
from
225bd1c
to
c4f3fe5
Compare
dosas
reviewed
Sep 10, 2024
dosas
reviewed
Sep 10, 2024
hstct
force-pushed
the
add_batching_for_publish
branch
5 times, most recently
from
221f0be
to
9b3cebd
Compare
hstct
changed the title
Existing tests should cover all of this. These are all performance boosts. |
hstct
force-pushed
the
add_batching_for_publish
branch
2 times, most recently
from
a035fbc
to
17dede0
Compare
hstct
force-pushed
the
add_batching_for_publish
branch
from
17dede0
to
8d62828
Compare
hstct
force-pushed
the
add_batching_for_publish
branch
2 times, most recently
from
f41bc2b
to
fded6a2
Compare
quba42
reviewed
Sep 18, 2024
There was a problem hiding this comment.
What I tested appears to work without changes, but at more than twice the speed from before.
What I have below are small nitpicks, or questions about points that look the most risky to me. They don't necessarily require a change.
What I did not test: Source packages sync, upload, repeated upload (interesting because of the change to the retrieve method).
hstct
force-pushed
the
add_batching_for_publish
branch
from
fded6a2
to
f0b639c
Compare
|
Simplified the PR and removed some of the "optimization" changes that are unrelated to this PR and they don't affect performance noticably. |
|
It all LGTM, the only remaining question is, if we need the batching. |
quba42
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1147